roles: keycloak role user mgt and kcadm updates

[spoore1]

Adding new methods to KeycloakUser class to extend user management support: delete, modify, set_password

Adding raise_on_error parameter to KeycloakUser methods so that they can be called for expected failure scenarios. This required adding raise_on_error to kcadm exec call.

[danlavu]

LG2M

[pbrezina]

Hi, see comments inside.

By the way, you say you add raise_on_error parameter, but I don't see it anywhere. Did you change your mind?

[pbrezina]

Would it be possible to implement get() also for groups and unify the id property for both objects? I.e.:

@property
def id(self) -> str:
    if self._id is None:
        obj = self.get()
        self._id = obj["id"]

    return self._id

@id.setter
def id(self, value: str) --> None:
    self._id = value

This way, you can avoid calling get() from the user's constructor when it is not needed for new users and both classes would handle it the same way.

[spoore1]

@pbrezina I updated the KeycloakGroup to add a get() method and modified the id setting. Let me know what you think.

[pbrezina]

Great, now we need one more thing - since you call get() from KeycloackObject, you need to add it as abstract method there. E.g.

from abc import ABC, abstractmethod

class KeycloakObject(ABC, BaseObject[KeycloakHost, Keycloak]):
    @abstractmethod
    def get(self) -> dict[str, list[str]]:
        """docstring"""
        pass

To avoid sssd_test_framework/roles/keycloak.py:100: error: "KeycloakObject" has no attribute "get" [attr-defined]

Remove the commented lines and we can merge.

[spoore1]

@pbrezina, I added abstract get() method to KeycloakObject class and removed comments I found. Anything else for this one? I just pushed a fix for the tox error also.

[pbrezina]

Ack, thank you.

[danlavu]

Looks good to me, thanks!