authentication: password change take retyped argument #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriki01
force-pushed
the
retyped_password
branch
from
91d2e23 to
82b1ad3
Compare
|
@patriki01 can you rebase on top of the master branch? Once this is done I'll proceed to merge this PR. |
patriki01
force-pushed
the
retyped_password
branch
from
82b1ad3 to
320bcdf
Compare
|
@ikerexxe Rebased. |
pbrezina
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I edited password change method that it takes additional argument
retyped. It is needed when the test needs to fail due to mismatched passwords. I also made a cleanup of this method (docstring valueraises, exit codes now make better sense, assert on line 994 removed)If you have any comments or suggestions do not hesitate to write.