-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: journalctl added #54
Conversation
It'd be nice to add a doc entry for this and provide the following examples,
assert client.utils.tools.journalctl(grep="search string").rc == 0 |
I added example usage as you proposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add the --system
and --user
options, I think I'm using them quite often.
However, this is only an optional improvement so I'm approving this PR.
I added those options @ikerexxe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hi, @danlavu can you prepare a list for most common tasks that are used by QE? I'm thinking that it would be good to convert this to standalone class that would provide generic cli call but also methods to handle the most common tasks. Also it should be possible to work only with messages generated by the test run (either by vacuuming journal during setup or by some other means) and dump journal into a file when a test is finished so we can download it as artifact. It'll be also good to move this to pytest-mh, since it is not strictly related to sssd/idm. |
@pbrezina ack @patriki01 I suppose we can take the comment about the assertions out then. |
Okay, I move it there: next-actions/pytest-mh#23 |
I added command for
journalctl
. I included only what I thought are most commonly used parameters. Feel free to suggest change.