passkey: avoid an infinite loop in cares in authentication of passkey

[madhuriupadhye]

The issue is an infinite loop in cares.
generate_unique_id() caused by 'LD_PRELOAD=/opt/random.so'.
generate_unique_id() is calling arc4random_buf() and the loop in cares
is keeping a list of old ids to avoid those. But arc4random_buf() is
overwritten by random.so and always returns the same value and as a
result the same id is always used and causes the infinite loop.

To make the environment only available to
passkey_child not to add those environment variable to
/etc/sysconfig/sssd but rename passkey_child.

Signed-off-by: Madhuri Upadhye [email protected]

[pbrezina]

Hi, I added copy and restore methods to pytest-mh fs. If I understand it correctly we want to:

1. Copy passkey_child -> passkey_child.orig
2. Mock passkey_child (write custom contents, exec passkey_child.orig)
3. Text authentication
4. Restore paskey_child and passkey_child.orig

The code should look like:

 def passkey(...):
    ...
    self.fs.copy("passkey_child", "passkey_child.orig")
    self.fs.write("passkey_child", "...passkey child contents")
    run_su = ... (we probably do not need to restart sssd anymore)
    playback_umockdev = ...
    run expect ...

    # Now this is probably not needed in passkey case, but if we want to restore the files immediately so original files are used for the rest of the test
    self.fs.restore("passkey_child")

[ikerexxe]

@pbrezina the restore function doesn't work, and I think that's the issue Madhuri is facing.

I created a simple test case to test this functionality:

@pytest.mark.topology(KnownTopology.LDAP)
def test_files_provider__example(client: Client, provider: GenericProvider):
    client.fs.copy("/usr/libexec/sssd/passkey_child", "/usr/libexec/sssd/passkey_child.orig")
    client.host.ssh.exec(["rm", "/usr/libexec/sssd/passkey_child"])
    client.fs.restore("/usr/libexec/sssd/passkey_child")
    pass

The copy works correctly, and I can find a file called /usr/libexec/sssd/passkey_child.orig with the content of /usr/libexec/sssd/passkey_child. But the restoration doesn't work and /usr/libexec/sssd/passkey_child never comes back. I reviewed the code and I thought that restoring /usr/libexec/sssd/passkey_child.orig would help, but that doesn't work either. Can you take a look to see what's happening?

[pbrezina]

@pbrezina the restore function doesn't work, and I think that's the issue Madhuri is facing.

I created a simple test case to test this functionality:

@pytest.mark.topology(KnownTopology.LDAP)
def test_files_provider__example(client: Client, provider: GenericProvider):
    client.fs.copy("/usr/libexec/sssd/passkey_child", "/usr/libexec/sssd/passkey_child.orig")
    client.host.ssh.exec(["rm", "/usr/libexec/sssd/passkey_child"])
    client.fs.restore("/usr/libexec/sssd/passkey_child")
    pass

The copy works correctly, and I can find a file called /usr/libexec/sssd/passkey_child.orig with the content of /usr/libexec/sssd/passkey_child. But the restoration doesn't work and /usr/libexec/sssd/passkey_child never comes back. I reviewed the code and I thought that restoring /usr/libexec/sssd/passkey_child.orig would help, but that doesn't work either. Can you take a look to see what's happening?

You did not backup /usr/libexec/sssd/passkey_child

  @pytest.mark.topology(KnownTopology.LDAP)
  def test_files_provider__example(client: Client, provider: GenericProvider):
+     client.fs.backup("/usr/libexec/sssd/passkey_child")
      client.fs.copy("/usr/libexec/sssd/passkey_child", "/usr/libexec/sssd/passkey_child.orig")
      client.host.ssh.exec(["rm", "/usr/libexec/sssd/passkey_child"])
      client.fs.restore("/usr/libexec/sssd/passkey_child")
      pass

copy only creates backup of the destination file because the source file is not touched

[pbrezina]

In the example from #55 (comment) write creates backup of /usr/libexec/sssd/passkey_child. In your code, there is no write so you have to call backup.

[madhuriupadhye]

In the example from #55 (comment) write creates backup of /usr/libexec/sssd/passkey_child. In your code, there is no write so you have to call backup.

After the backup, it worked as expected. Thank you!

[pbrezina]

Please, let me know when it is ready for final review.

[madhuriupadhye]

Please, let me know when it is ready for final review.

Yes, Done with my changes, please check again.

[pbrezina]

Ack, just please change the commit subject, e.g. passkey: avoid infinite loop in cares

[spoore1]

LGTM but, I think we need a new version of pytest-mh built and the requirements updated to fix the tox error: LinuxFileSystem" has no attribute "copy" [attr-defined

[pbrezina]

LGTM but, I think we need a new version of pytest-mh built and the requirements updated to fix the tox error: LinuxFileSystem" has no attribute "copy" [attr-defined

Yes. @madhuriupadhye can you add 18b47de but bump the version to 1.0.7 please?

I will release next version of pytest-mh when remaining pull requests are merged.