Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify direct nested group processing #7763

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

ondrejv2
Copy link
Contributor

Simplifies direct nested group processing - now single LDAP request is needed to parse nested groups
Replaces PR #7596

@ondrejv2
Copy link
Contributor Author

Can anyone shed some light into the tests? I do not quite understand why they fail. It works for me with AD.

@sumit-bose
Copy link
Contributor

Can anyone shed some light into the tests? I do not quite understand why they fail. It works for me with AD.

Hi,

please call make check in the SSSD source tree after compiling SSSD, the nestedgroups-tests should fail. You can nestedgroups-tests individually as well and nestedgroups-tests -d 10 might give some helpful debug output.

HTH

bye,
Sumit

@ondrejv2
Copy link
Contributor Author

please call make check in the SSSD source tree after compiling SSSD, the nestedgroups-tests should fail. You can nestedgroups-tests individually as well and nestedgroups-tests -d 10 might give some helpful debug output.

Hi,
Well I can't even compile tests myself for some reason:

  CC       src/tests/cmocka/nestedgroups_tests-common_mock_be.o
  CC       src/providers/ldap/nestedgroups_tests-sdap_async_nested_groups.o
  CC       src/providers/ldap/nestedgroups_tests-sdap_ad_groups.o
  CC       src/providers/ipa/nestedgroups_tests-ipa_dn.o
  CCLD     nestedgroups-tests
/usr/bin/ld: cannot find ./.libs/libdlopen_test_providers.a: No such file or directory
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:16460: nestedgroups-tests] Error 1
make[3]: Leaving directory '/opt/sssd'

any idea?

@sumit-bose
Copy link
Contributor

Hi,

are you using any configure options or CFLAGS, LDFLAGS in the environment? It looks like you are trying to build a static version of SSSD which is not supported.

bye,
Sumit

@ondrejv2 ondrejv2 marked this pull request as draft December 20, 2024 12:31
@ondrejv2
Copy link
Contributor Author

Hi,
I figured eventually - I was missing some dependencies. Can run checks now and they fail because these checks leave the objectClass attribute of the nested group member empty - hence my code fails.
Now I have two options:

  • fix the checks so they populate objectClass attr correctly.
  • fix my code to check value objectCategory attr instead (that will be slightly more tricky I guess so I would prefer option 1).

What do you think?
Converted to draft meanwhile.

Thanks
Ondrej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants