Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support, round 1 #7765

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add FreeBSD support, round 1 #7765

wants to merge 5 commits into from

Conversation

fluffykhv
Copy link

Port patches from FreeBSD ports tree (https://github.com/freebsd/freebsd-ports/tree/main/security/sssd2/files), round one

@alexey-tikhonov
Copy link
Member

Hi @fluffykhv,
thank you for the contribution.

Is "Add FreeBSD support, round 1" a single huge patch in FreeBSD repo?
If this is a set of patches, wouldn't it make sense to have a commit per patch to make the review easier?

@emaste
Copy link

emaste commented Dec 26, 2024

Patches in the FreeBSD ports collection are typically per-file rather than per-logical-change, so it may not be straightforward to recreate an incremental patch set. If you look at the URL above you'll see the per-file patches. This is admittedly not ideal from the perspective of collaboration with an upstream.

Looking at the history (e.g. https://github.com/freebsd/freebsd-ports/commits/main/security/sssd2/files) gives some insight, and you can see some logical changes that could be applied individually e.g. freebsd/freebsd-ports@9a40ff8.

If you want a patch set of logical changes we'll have to curate the patches in the ports tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants