Remove dynamic page titles + include in Layout consistently #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Layout
component, where that component was already available.(1) is a fix for #205, although dynamic page titles may need to be reintroduced later if people express benefit from this. If this is the case, note that we will need to use
getServerSideProps
to ensure the information is available upon page load, instead of a hook, which causes the flickering.(2) was something I noticed, and I figured could help streamline the code. It is a minor thing but when adding up tens of these minor fixes across PRs, they start adding up 😊