Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic page titles + include in Layout consistently #375

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

chartgerink
Copy link
Member

This PR does two things:

  1. Remove all dyanmic page titles in favor of static page titles. Fixes head --> title sometimes flickers #205.
  2. Move all the page titles into the Layout component, where that component was already available.

(1) is a fix for #205, although dynamic page titles may need to be reintroduced later if people express benefit from this. If this is the case, note that we will need to use getServerSideProps to ensure the information is available upon page load, instead of a hook, which causes the flickering.

(2) was something I noticed, and I figured could help streamline the code. It is a minor thing but when adding up tens of these minor fixes across PRs, they start adding up 😊

@doomlab doomlab merged commit f0bc199 into dev Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

head --> title sometimes flickers
2 participants