Streamline table columns #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chartgerink
force-pushed
the
update/tables
branch
from
80c6b99 to
c893a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines the table columns, to deduplicate some of the column code.
I did some testing, but not super thorough, given that I am not 100% of where everything is used. In essence I only deduplicated where the columns were equivalent, or where only the label differed.
UPDATE: I force-pushed here to remove some changes that ended up not passing the typechecks, which the automation caught. It appears the column helper has types that I was not aware of while suggesting the first, more comprehensive changes.