Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components/molecule/dataCounter): Allow input to be edited #2784

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(components/molecule/dataCounter): Allow input to be edited #2784

merged 1 commit into from
Nov 28, 2024

Conversation

alfdocimo
Copy link
Contributor

@alfdocimo alfdocimo commented Nov 28, 2024 •
edited
Loading

Category/Component

TASK:

Description, Motivation and Context

Types of changes

Screen.Recording.2024-11-28.at.14.11.29.mov
  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

@github-actions GitHub Actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.06↑ ≍ 0.13↑ ≍ 0.03↑ ≍ 0.03↑
% 75.94 64.1 65.73 77.71
ABS 3378 / 4448 2073 / 3234 658 / 1001 3197 / 4114

oriolpuig
oriolpuig approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@oriolpuig oriolpuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alfdocimo alfdocimo merged commit 4fae296 into master Nov 28, 2024
7 checks passed
@alfdocimo alfdocimo deleted the feat/allow-input-editable branch November 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oriolpuig oriolpuig oriolpuig approved these changes

@andresin87 andresin87 andresin87 approved these changes

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@andresz1 andresz1 Awaiting requested review from andresz1 andresz1 is a code owner

Assignees

@alfdocimo alfdocimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfdocimo @andresin87 @oriolpuig