Feature.addpatchposition #381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne-Rutten/cnaas-nms into feature.addpatchposition
|
| updated = False | ||
| intfs = session.query(Interface).filter(Interface.device == dev).all() | ||
| patch_positions = [intf.data["patch_position"] for intf in intfs if "patch_position" in intf.data] | ||
| print(patch_positions) |
There was a problem hiding this comment.
these lines looks like some left over debug info maybe?
| @@ -271,7 +271,7 @@ def populate_device_vars( | |||
| ifindexnum = 0 | |||
| if "ifclass" not in intf: | |||
| continue | |||
| extra_keys = ["aggregate_id", "enabled", "cli_append_str", "metric", "mtu", "tags"] | |||
| extra_keys = ["aggregate_id", "enabled", "cli_append_str", "metric", "mtu", "tags", "patch_postion"] | |||
There was a problem hiding this comment.
this is for dist/core devices, if you want to have an option for patch_position on those devices as well you need to make some changes in settings_fields.py as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch positions to the interfaces. Make sure that the patch positions are unique per device.