Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update change pw #1730

Closed
wants to merge 42 commits into from
Closed

update change pw #1730

wants to merge 42 commits into from

Conversation

eunjuhuss
Copy link
Contributor

Description:

  • Remove the current password input.
  • Add a confirmation page after a successful password change
  • Update the heading test
  • Use a toggle switch instead of a link button to switch between the suggested password page and the custom password page

For reviewer:

  • Read the above description
  • Reviewed the code changes
  • Navigate to the branch (pulled the latest version)
  • Run the code and been able to execute the expected function
  • Check any styling on both desktop and mobile sizes

eunjuhuss added 30 commits May 28, 2024 15:40
@eunjuhuss
Update heading and paragraph
8f931d1
@eunjuhuss
Remove current password input
1d014de
@eunjuhuss
Adjust heading text
50386ef
@eunjuhuss
Remove old password requirement for change password endpoint
384c49d
@eunjuhuss
Add border-bottom
1dcb2a2
@eunjuhuss
Remove ChangePasswordForm
8d9c831
@eunjuhuss
Fix issue, A form label must be associated with a control
42861d8
@eunjuhuss
Ajust css and paragraph text
ccf81b8
@eunjuhuss
Save temporary
c5b0f80
@eunjuhuss
Remove container
f09ec0c
@eunjuhuss
Rename class for reusability
e4b167e
@eunjuhuss
Change textInput to customInput
fbc1799
@eunjuhuss
Add InputType
f7a2824
@eunjuhuss
Add splash, when suggested_password is absentm the spinner spins
ec992e8
@eunjuhuss
Render passwordStrengthMeter if it exists
9cc87aa
@eunjuhuss
Change the meter max to 5 and render error message if props.password …
0281657 
…is not undefined
@eunjuhuss
Change div-> fieldset and add className
34f5df3
@eunjuhuss
Add meter color
2f9c760
@eunjuhuss
Moved strengthMeter below error message
2ca4778
@eunjuhuss
Add export for PasswordInputElement
6087875
@eunjuhuss
Create NewPAsswordInput
d992986
@eunjuhuss
Add placeholder for passwordinputs
44302c6
@eunjuhuss
Adjust meter styling
d27176f
@eunjuhuss
Clean up after removing ChangePasswordForm component
66a4f92
@eunjuhuss
Resolved issue where error message no longer occure after input value…
8cba171 
… strings are removed
@eunjuhuss
Update test due to component changes
889ae05
@eunjuhuss
Adjust meter error text position and color, font size
46f992f
@eunjuhuss
Create a separate toggle component for reusability
5ad1bac
@eunjuhuss
Clean up
b835caf
@eunjuhuss
Add a condition to prevent showing the error message
486fc11
@eunjuhuss eunjuhuss closed this May 31, 2024
@eunjuhuss eunjuhuss reopened this May 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@eunjuhuss eunjuhuss closed this May 31, 2024
@eunjuhuss eunjuhuss deleted the eunju-chanage-pw branch September 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eunjuhuss