New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify html structure #1937

Merged

cartja merged 7 commits into main from eunju-unify-html-stucture

Dec 17, 2024

Contributor

eunjuhuss commented Dec 16, 2024

Description:

Removed the id and added a class name instead.
the Fieldset should be inside the form
Removed unneccary Fieldset

For reviewer:

Read the above description
Reviewed the code changes
Navigate to the branch (pulled the latest version)
Run the code and been able to execute the expected function
Check any styling on both desktop and mobile sizes

eunjuhuss added 7 commits

December 13, 2024 09:52


          Remove extra div inside article

e2d047f


          Remove ID for article

f1d2fa7


          Clean up

6dbec76


          Remove ID

7a3e306


          Id -> className

7f463d5


          Remove fieldset

80439f7


          Change the place of the <fieldset> and <form>

afdb66c

sonarqubecloud bot commented Dec 16, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cartja merged commit 967cb00 into main

15 checks passed

cartja deleted the eunju-unify-html-stucture branch

December 17, 2024 10:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet