Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support d flag for regular expressions #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zherczeg
Copy link
Contributor

No description provided.

@zherczeg zherczeg marked this pull request as ready for review September 15, 2022 10:43
@zherczeg zherczeg force-pushed the regexp_d branch 2 times, most recently from 48100fa to 573429a Compare September 15, 2022 12:18
Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksh8281
Copy link
Contributor

ksh8281 commented Sep 19, 2022

IMO we need to add d flag into RegExpOption in EscargotPublic.h

@zherczeg zherczeg force-pushed the regexp_d branch 3 times, most recently from 2e09e32 to d360f11 Compare September 20, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants