[Fix] MSVC C4201 warning

Temp fix MSVC C4201 warning that shouldn't trigger (using std=c11) in Rectangle2D.hpp
SapphireSuite · Mar 31, 2024 · 1ad3317 · 1ad3317
1 parent 9b13e57
commit 1ad3317
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -21,6 +21,9 @@ add_library(SA_Maths STATIC)
 SA_ConfigureTarget(SA_Maths)
 SA_TargetSources(SA_Maths)
 
+### Temp required to fix MSVC C4201 in Rectangle2D.hpp
+target_link_libraries(SA_Maths PUBLIC SA_Support)
+
 
 
 # Option

diff --git a/Include/SA/Maths/Geometry/Rectangle2D.hpp b/Include/SA/Maths/Geometry/Rectangle2D.hpp
@@ -7,6 +7,8 @@
 
 #include <SA/Maths/Space/Vector2.hpp>
 
+#include <SA/Support/Pragma.hpp>
+
 /**
 *	\file Rectangle2D.hpp
 *
@@ -27,6 +29,8 @@ namespace SA
 	template <typename T>
 	struct Rect2D
 	{
+		SA_PRAGMA_SDWARN_MSVC(4201)
+
 		union
 		{
 			/// offset.
@@ -57,6 +61,8 @@ namespace SA
 			};
 		};
 
+		SA_PRAGMA_EDWARN_MSVC()
+
 		/// Default constructor.
 		Rect2D() = default;
 

diff --git a/ThirdParty/SA/CMakeLists.txt b/ThirdParty/SA/CMakeLists.txt
@@ -2,6 +2,9 @@
 
 # Entrypoints
 
+### Temp required to fix MSVC C4201 in Rectangle2D.hpp
+SA_FetchModule(Support)
+
 if(SA_MATHS_USE_LOGGER_OPT)
 
 	SA_FetchModule(Logger)