Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target os name due to RHELC-1737 #17208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update target os name due to RHELC-1737 #17208

wants to merge 1 commit into from
+6 −3

Conversation

shweta83
Copy link
Contributor

Problem Statement

Bug#RHELC-1737: Incorrect target os name post conversion to RHEL

Solution

Updated assertion

Related Issues

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 19, 2024
@shweta83 shweta83 requested review from a team as code owners December 19, 2024 11:34
@shweta83 shweta83 force-pushed the skip_rhel_os_check branch 2 times, most recently from 1bf68ea to e24e014 Compare December 19, 2024 11:43
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos_with_pre_conversion_template_check[centos8]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9680
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos_with_pre_conversion_template_check[centos8] --external-logging
Test Result : ========== 1 passed, 3 deselected, 16 warnings in 1759.55s (0:29:19) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 19, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9681
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ============ 3 passed, 772 warnings, 1 error in 6235.11s (1:43:55) =============

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Dec 20, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9694
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 718 warnings, 1 error in 4975.29s (1:22:55) ========

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9699
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 699 warnings, 1 error in 4992.45s (1:23:12) ========

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9713
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 639 warnings, 1 error in 4411.28s (1:13:31) ========

Gauravtalreja1
Gauravtalreja1 reviewed Jan 2, 2025
View reviewed changes
tests/foreman/api/test_convert2rhel.py
@@ -328,6 +328,8 @@ def test_convert2rhel_oracle_with_pre_conversion_template_check(
assert host_content['facts']['conversions::success'] == 'true'
convert2rhel_facts = json.loads(oracle.execute('cat /etc/rhsm/facts/convert2rhel.facts').stdout)
assert convert2rhel_facts['conversions.env.CONVERT2RHEL_THROUGH_FOREMAN'] == '1'
# https://issues.redhat.com/browse/RHELC-1737
target_os_name = 'Oracle' if is_open('RHELC-1737') else 'Red Hat'
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle tests are failing currently in PRT, but I think this would return as Oracle Linux, could you check and confirm?
And, OEL7 and CentOS7 conversion failures are due to known regression in analyze template

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle 8 is failing because of template issue. The assertion will pass once I fix the template for oracle 8 which is currently I am working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

Assignees

@shweta83 shweta83

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @Gauravtalreja1