Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): upgrade angular to v18 and other npm dependencies before sdk refactor #1626

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Oct 25, 2024

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Upgrade Angular to version 18 and update npm dependencies. Refactor ESLint configuration and SCSS files to align with new Angular and Material Design standards. Adjust event emitter names and date handling to comply with updated Angular ESLint rules. Remove unused imports and improve test maintainability.

Enhancements:

  • Update Angular to version 18 and upgrade other npm dependencies.
  • Refactor ESLint configuration to include new Angular and NgRx rules.
  • Modify SCSS files to use updated Material Design functions and palettes.
  • Refactor event emitter names in MetadataInputComponent to avoid conflicts with Angular ESLint rules.
  • Update date handling in ProposalFilterComponent and DateRangeFilterComponent to use string types.

Chores:

  • Remove unused NgxMatDatetimePickerModule imports and related code.
  • Replace direct string usage in tests with variable references to improve maintainability.

@nitrosx nitrosx added DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK labels Nov 1, 2024
@bpedersen2
Copy link
Contributor

I suggest to rebase this onto #1669 (or master once the PR is merged.

@martin-trajanovski
Copy link
Collaborator Author

I suggest to rebase this onto #1669 (or master once the PR is merged.

@bpedersen2 I will try to look into this after the new sdk is merged in. Thanks for your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants