feat!: rework AbstractVectorOfArray, use new SymbolicIndexingInterface #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing the |
|
I've tried to make |
This was referenced Oct 27, 2023
YingboMa
approved these changes
Nov 7, 2023
- linear indexing is deprecated - firstindex and lastindex methods removed - eachindex iterates over `CartesianIndex` pointing to individual elements
- resolves method ambiguities - reduces total number of methods - also added a minimal interface for DiffEqArray
AayushSabharwal
force-pushed
the
as/indexing-rework
branch
from
80cc2d8 to
22a81f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractVectorOfArraydoesn't subtypeAbstractArrayissymbollikeCloses #237