Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broadcasted assignment to VOA of StaticArrays #304

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

Why does CI randomly get cancelled like that?

@ChrisRackauckas
Copy link
Member

fail fast

@AayushSabharwal
Copy link
Member Author

Ah, so 1.6 is making it fail? I'll remove 1.6 CI so this actually runs

@ChrisRackauckas
Copy link
Member

yes exactly. Just rebase onto master, it's being prepared to release all together

@AayushSabharwal
Copy link
Member Author

This might need another rebase once #298 is merged

@ChrisRackauckas
Copy link
Member

Rebase and 🙏

@ChrisRackauckas
Copy link
Member

Looks like you have an infinite loop somewhere?

@ChrisRackauckas ChrisRackauckas merged commit b7da0a2 into SciML:master Dec 20, 2023
11 of 16 checks passed
@AayushSabharwal AayushSabharwal deleted the as/broadcast-fix branch December 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants