Updated README.md file #12
Conversation
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
jferas
force-pushed
the
update-readme
branch
3 times, most recently
from
2fcf6fb to
c9e24c7
Compare
jferas
force-pushed
the
update-readme
branch
from
c9e24c7 to
2e6cb9e
Compare
jferas
force-pushed
the
update-readme
branch
from
2e6cb9e to
252d828
Compare
README.md
Outdated
|
|
||
| This `slither-args` field is where you can change the Slither configuration for your project, and the defaults above can of course be changed. | ||
| Some tests will not show up when running `scopelint spec` because the methods they are testing are inherited in the `RadworksGovernor`. In order to get an accurate picture of the tests with `scopelint spec` add an explicit `propose` method to the `RadworksGovernor`. It should look like this: |
There was a problem hiding this comment.
Currently this is the extent of what i see from scopelint spec. Do you see the same thing?
There was a problem hiding this comment.
I see the same thing. I think this comment is saying if you want to see the tests on the propose method then you would have to add a propose method to the RadworksGovernor contract because scopelint does not show tests on inherited methods.
There was a problem hiding this comment.
cool -- shouldn't it still show more tests though, the ones unrelated to propose? Anyway, don't let this block merge, if it's an issue in the future then we can revise.
There was a problem hiding this comment.
At this point it the codebase it doesn't look like it should. It finds the tests to show based on the name of the test contracts. Right now the only test contracts with tests are Propose and Constructor
README.md
Outdated
| [^sarif]: | ||
| [SARIF](https://sarifweb.azurewebsites.net/) (Static Analysis Results Interchange Format) is an industry standard for static analysis results. | ||
| You can read learn more about SARIF [here](https://github.com/microsoft/sarif-tutorials) and read about GitHub's SARIF support [here](https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning). | ||
| This repo heavily leverages fuzz fork tests causing a significant number of RPC requests to be made. We leverage caching to minimize the number of RPC calls after the tests are run for the first time, but running these tests for the first may cause timeouts and consume a significant number of RPC calls. |
There was a problem hiding this comment.
| This repo heavily leverages fuzz fork tests causing a significant number of RPC requests to be made. We leverage caching to minimize the number of RPC calls after the tests are run for the first time, but running these tests for the first may cause timeouts and consume a significant number of RPC calls. | |
| This repo heavily leverages fuzz fork tests causing a significant number of RPC requests to be made. We leverage caching to minimize the number of RPC calls after the tests are run for the first time, but running these tests for the first time may cause timeouts and consume a significant number of RPC calls. |
jferas
force-pushed
the
update-readme
branch
2 times, most recently
from
50458d4 to
212a699
Compare
jferas
force-pushed
the
update-readme
branch
from
1aaa4b1 to
1deaf32
Compare
No description provided.