Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proper types for seeds #212

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

wielopolski
Copy link
Collaborator

Jira issue(s)

https://selleolabs.atlassian.net/jira/software/projects/LC/boards/3?selectedIssue=LC-220

Overview

This PR improves seeds for staging and production.

@wielopolski wielopolski force-pushed the feat/mw_lc_220_proper_types_for_seeds branch from d7537e7 to a7eea37 Compare November 6, 2024 16:26
@wielopolski wielopolski marked this pull request as ready for review November 6, 2024 16:26
Comment on lines 26 to 27
import { categoryCreateSchema, CategoryInsert } from "../schemas/createCategorySchema";
import { categoryUpdateSchema, CategoryUpdateBody } from "../schemas/updateCategorySchema";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { categoryCreateSchema, CategoryInsert } from "../schemas/createCategorySchema";
import { categoryUpdateSchema, CategoryUpdateBody } from "../schemas/updateCategorySchema";
import type { categoryCreateSchema, CategoryInsert } from "../schemas/createCategorySchema";
import type { categoryUpdateSchema, CategoryUpdateBody } from "../schemas/updateCategorySchema";

Copy link
Member

@typeWolffo typeWolffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@typeWolffo typeWolffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wielopolski wielopolski merged commit bfc1b99 into main Nov 7, 2024
6 checks passed
@wielopolski wielopolski deleted the feat/mw_lc_220_proper_types_for_seeds branch November 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants