Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize video player import to use lazy loading in Video component #235

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

typeWolffo
Copy link
Member

Jira issue(s)

https://selleolabs.atlassian.net/browse/LC-382

Overview

https://github.com/cookpete/react-player#usage

If your build system supports import() statements, use react-player/lazy to lazy load the appropriate player for the url you pass in. This adds several reactPlayer chunks to your output, but reduces your main bundle size.

Screenshots

Screen.Recording.2024-11-20.at.10.45.48.AM.mov

@typeWolffo typeWolffo added the review me 👀 PR is ready to be reviewed label Nov 20, 2024
@typeWolffo typeWolffo self-assigned this Nov 20, 2024
@typeWolffo typeWolffo marked this pull request as ready for review November 20, 2024 09:51
@typeWolffo typeWolffo merged commit eadffba into main Nov 20, 2024
4 checks passed
@typeWolffo typeWolffo deleted the jw_fix_lc-382_file_player branch November 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me 👀 PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants