feat: add confirmation modal #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszszczecina
requested review from
typeWolffo,
piotr-pajak and
wielopolski
mateuszszczecina
changed the title
typeWolffo
approved these changes
Dec 17, 2024
| @@ -4,3 +4,11 @@ export type LessonTypes = | |||
| | "video" | |||
| | "external_video" | |||
| | undefined; | |||
|
|
|||
| export enum DeleteContentType { | |||
There was a problem hiding this comment.
Consider replacing enum with a const object - it would give us better type guarantees.
There was a problem hiding this comment.
I also see that DeleteContentType is very similar to the LessonType from Admin/EditCourse/EditCourse.types.ts maybe it is worth to create some shared, extendable types?
There was a problem hiding this comment.
Ye sure, i will change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
https://selleolabs.atlassian.net/browse/LC-483
Overview
Add confirmation modal for delete content
Screenshots