Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Chapter and Lesson modules into SCORM processing #302

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

typeWolffo
Copy link
Member

@typeWolffo typeWolffo commented Dec 18, 2024

Jira issue(s)

LC-489

Overview

  • now, during scorm processing the chapters are generated as in every other course

Screenshots

image

@typeWolffo typeWolffo added the Status: WIP 🏗 Work in progress label Dec 18, 2024
@typeWolffo typeWolffo self-assigned this Dec 18, 2024
@typeWolffo typeWolffo force-pushed the jw_feat_lc-489_scorm_course_chapters branch from 277d176 to 87a2a96 Compare December 19, 2024 13:31
const items = Array.isArray(organization.item) ? organization.item : [organization.item];

return items.map((chapterItem: any, chapterIndex: number) => {
const subItems = chapterItem.item
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be simplified in next PR

return {
title: lessonTitle,
identifier: lessonItem.$.identifier,
// @ts-expect-error tet
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR

@@ -69,20 +69,20 @@ export default function CoursesViewPage() {
</BreadcrumbItem>
</BreadcrumbList>
<div className="flex flex-col md:flex-row h-full gap-6">
{course.isScorm ? (
{/* {course.isScorm ? (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR

@typeWolffo typeWolffo added review me 👀 PR is ready to be reviewed and removed Status: WIP 🏗 Work in progress labels Dec 19, 2024
@typeWolffo typeWolffo marked this pull request as ready for review December 19, 2024 13:36
Copy link
Collaborator

@wielopolski wielopolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🍻

import { S3Service } from "src/s3/s3.service";

import { SCORM } from "../constants/scorm.consts";
import { ScormRepository } from "../repositories/scorm.repository";

import type { UUIDType } from "src/common";

type ScormChapter = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In next PR extract it to separate file

@typeWolffo typeWolffo merged commit 7ba3390 into main Dec 19, 2024
5 of 7 checks passed
@typeWolffo typeWolffo deleted the jw_feat_lc-489_scorm_course_chapters branch December 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me 👀 PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants