Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms: feat 517 secure form #315

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

mateuszszczecina
Copy link
Collaborator

Jira issue(s)

https://selleolabs.atlassian.net/browse/LC-517

Overview

Add modal to protect the user from data loss in questions form

@mateuszszczecina mateuszszczecina added the review me 👀 PR is ready to be reviewed label Dec 27, 2024
@mateuszszczecina mateuszszczecina self-assigned this Dec 27, 2024
Copy link
Collaborator

@wielopolski wielopolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 🍻
I left some comments

@@ -1,5 +1,5 @@
export const LESSON_TYPES = {
TEXT: "text",
TEXT: "text_block",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it, we can use text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i will change it back, and adjust on frontend to be also "text"

@@ -175,6 +175,7 @@ export class AdminLessonService {
});
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@@ -1607,7 +1638,7 @@ export const niceCourses: NiceCourseData[] = [
type: LESSON_TYPES.TEXT,
title: "Key Concepts and Terminologies in AI",
description:
'<p>Artificial Intelligence (AI) refers to the simulation of human intelligence in machines programmed to think, learn, and make decisions. Below are some key concepts and terminologies essential to understanding AI:</p><ul><li><strong>Machine Learning (ML):</strong> A subset of AI focused on creating algorithms that allow computers to learn from and make predictions based on data. Example: A recommendation system suggesting movies based on your viewing history.</li><li><strong>Neural Networks:</strong> Inspired by the human brain, these are algorithms designed to recognize patterns and process data in layers, enabling tasks like image and speech recognition.</li><li><strong>Natural Language Processing (NLP):</strong> This involves teaching machines to understand, interpret, and generate human language. Example: Virtual assistants like Alexa or Siri.</li><li><strong>Computer Vision:</strong> A field of AI that enables computers to interpret and process visual data, such as images and videos. Example: Facial recognition technology.</li><li><strong>Deep Learning:</strong> A more complex subset of ML that uses large neural networks to analyze massive amounts of data and solve intricate problems, such as self-driving cars.</li><li><strong>Supervised vs. Unsupervised Learning:</strong><br>- <strong>Supervised Learning:</strong> The AI is trained on labeled data (e.g., images labeled as "cat" or "dog").<br>- <strong>Unsupervised Learning:</strong> The AI identifies patterns in unlabeled data without explicit instructions.</li><li><strong>Big Data:</strong> The large volume of structured and unstructured data generated by businesses and devices, which is essential for training AI models.</li><li><strong>Automation:</strong> AI is often used to automate repetitive tasks, freeing up human resources for more complex activities.</li><li><strong>Ethics in AI:</strong> As AI becomes more powerful, ensuring its ethical use (e.g., avoiding bias in decision-making) is critical for building trust.</li></ul><h3>Why These Concepts Matter</h3><p>Understanding these basic AI terms is the first step toward recognizing how AI can be applied in business. Each concept represents a building block of AI\'s potential to transform industries by increasing efficiency, improving decision-making, and creating innovative solutions.</p>',
"<p>Artificial Intelligence (AI) refers to the simulation of human intelligence in machines programmed to think, learn, and make decisions.</p>",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep longer version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right

@@ -95,8 +95,8 @@ export async function createNiceCourses(
lessonData.type === LESSON_TYPES.PRESENTATION
? "pptx"
: lessonData.type === LESSON_TYPES.VIDEO
? "mp4"
: null,
? "mp4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a messy shift

@@ -9,8 +9,8 @@ import type { UserWithCredentials } from "test/factory/user.factory";
type CamelToSnake<T extends string, P extends string = ""> = string extends T
? string
: T extends `${infer C0}${infer R}`
? CamelToSnake<R, `${P}${C0 extends Lowercase<C0> ? "" : "_"}${Lowercase<C0>}`>
: P;
? CamelToSnake<R, `${P}${C0 extends Lowercase<C0> ? "" : "_"}${Lowercase<C0>}`>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a messy shift

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this change come from?
Haven't we decided to stop using text_block throughout the entire application?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then i can back to "text" and change "text_block" -> "text" on frontend side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me 👀 PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants