Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports: Update vim editor to v8.2.5056 #25559

Closed
wants to merge 5 commits into from

Conversation

djwisdom
Copy link
Contributor

@djwisdom djwisdom commented Dec 19, 2024

Also updated the version from normal to huge

@djwisdom djwisdom requested a review from timschumi as a code owner December 19, 2024 05:00
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 19, 2024
@djwisdom djwisdom marked this pull request as draft December 19, 2024 05:08
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 19, 2024
@djwisdom djwisdom marked this pull request as ready for review December 19, 2024 05:21
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 19, 2024
@nico
Copy link
Contributor

nico commented Dec 19, 2024

Your commits got mixed up: The first one updates the .sh file and also contains the huge file, while the second updates the table.

Instead, one commit should contain the version update in both .sh file and table, and the 2nd commit should change to huge. (Please also mention the change to huge in the PR description.)

@nico nico added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Dec 19, 2024
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author labels Dec 19, 2024
@nico
Copy link
Contributor

nico commented Dec 19, 2024

Mind putting the change to huge into a separate commit?

@timschumi timschumi added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Dec 19, 2024
@djwisdom djwisdom marked this pull request as draft December 19, 2024 19:37
@github-actions github-actions bot removed the ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author label Dec 19, 2024
@djwisdom djwisdom closed this Dec 19, 2024
@djwisdom djwisdom deleted the ports-vim-update branch December 19, 2024 19:49
@nico
Copy link
Contributor

nico commented Dec 19, 2024

git rebase -i master is your friend! Put d next to commits 2 and 3, s next to commit 4, save, and everything should basically be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants