Browser: Add find-in-page UI #25580
Open
Browser: Add find-in-page UI #25580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
What happened here? This isn't even close to compiling. Did you forgot to add a few files to the commit? |
nico
added
⏳ pr-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation adds a find-in-page feature to the browser, allowing users to search for text within the active web page, navigate between matches, and clear highlights. In
Tab.cpp, methodsfind_in_page,find_next, andfind_previousare added to handle search operations by interacting with the web view (WebView). InBrowserWindow.cpp, a search bar UI is integrated with aTextBoxfor input, "Next" and "Previous" buttons for navigation, and a "Close" button to hide the search bar. The search bar is triggered via a menu action (e.g.,Ctrl+F). TheWebViewis extended with methods likesearch_for_text,find_next_match, andclear_find_highlightsto manage the search functionality and highlighting within the web content. This cohesive integration provides seamless in-page search capabilities.