Create Binary To Decimal Converter.js #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parser is a Binary to Decimal Converter designed to parse user input in a specific format and convert binary values to decimal. By providing a command with a binary code, this parser uses an external API to fetch and return the decimal equivalent. Activation Example To use this converter, simply enter the command in this format: !converttoDecimal <binary_code> For example: !converttoDecimal 1011 Features Regex-based Command Parsing: The parser validates the input command using a regular expression, ensuring only binary codes are accepted. Binary Validation: It checks the user input for valid binary numbers. API Call for Conversion: It uses the https://networkcalc.com/api/binary/<binary_code> API to convert binary to decimal. Slackbot Integration: Once the conversion is complete, the decimal value is sent back to the user in formatted message. *Binary to Decimal Conversion:* • Binary value: 1011 • Decimal value: 11
SapphicFire
requested changes
Nov 1, 2024
Comment on lines
2
to
3
| activation_example:!converttoDecimal <binary_code> | ||
| regex:^!converttoDecimal |
There was a problem hiding this comment.
Please remove this capitalisation, as this adds confusion when compared to all other parsers. Additionally, it is not clear that this parser converts from binary to decimal. It might be worthwhile making it something like !bin2dec
There was a problem hiding this comment.
ok I wil make changes
Comment on lines
13
to
14
| var match = input.match(/!converttoDecimal (\d+)/); // check input format | ||
| var expression = match ? match[1] : ""; |
There was a problem hiding this comment.
It's not clear from other details about this parser, that this will not support multiple bytes (i.e. 00110101 11111111) or breaks in the binary
There was a problem hiding this comment.
Ok I will rectify the code
| // check the valid binary code in if statement | ||
| if(binaryCheckregx.test(expression)){ | ||
| var result = evaluateBinaryExpression(expression); // call to evaluateBinaryExpression | ||
| var DecimalresultSlackMessage = "* Binary to Decimal Conversion :*\n" + "• *Binary value*: " + expression + "\n" + "• *Decimal value*: " + result.converted + "\n"; // slack markdown message format |
There was a problem hiding this comment.
This does not use unordered lists so does not use slack markdown
Resolve the Issue raised 1) Please remove this capitalisation, as this adds confusion when compared to all other parsers. Additionally, it is not clear that this parser converts from binary to decimal. It might be worthwhile making it something like !bin2dec 2) It's not clear from other details about this parser, that this will not support multiple bytes (i.e. 00110101 11111111) or breaks in the binary 3) This does not use unordered lists so does not use slack markdown Now, this parser will accept the binary code with spaces and give output as a decimal value. Change the activation to !bin2dec <binary code> and also remove the slack markdown and show output as normal text.
Pradeep567iaf
commented
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parser is a Binary to Decimal Converter designed to parse user input in a specific format and convert binary values to decimal. By providing a command with a binary code, this parser uses an external API to fetch and return the decimal equivalent.
Activation Example
To use this converter, simply enter the command in this format:
!converttoDecimal <binary_code>
For example:
!converttoDecimal 1011
Features
Regex-based Command Parsing: The parser validates the input command using a regular expression, ensuring only binary codes are accepted.
Binary Validation: It checks the user input for valid binary numbers.
API Call for Conversion: It uses the https://networkcalc.com/api/binary/<binary_code> API to convert binary to decimal.
Slackbot Integration: Once the conversion is complete, the decimal value is sent back to the user in formatted message.
Binary to Decimal Conversion:
• Binary value: 1011
• Decimal value: 11