Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'sort' query parameter to 's' #40

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

loevgaard
Copy link
Member

@loevgaard loevgaard commented Dec 5, 2024

This is only done to make the query string shorter. There will be another PR doing the same for facets/filters, so we end up having p, s, f, and q as root level query parameters for the search

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.08%. Comparing base (ef4a199) to head (40c4817).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Form/Builder/SearchFormBuilder.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage     32.08%   32.08%           
  Complexity      556      556           
=========================================
  Files           112      112           
  Lines          1920     1920           
=========================================
  Hits            616      616           
  Misses         1304     1304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit 1b48c88 into master Dec 5, 2024
37 of 38 checks passed
@loevgaard loevgaard deleted the rename-sort-to-s branch December 5, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant