Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename facet form builders to filter form builders because people use the word 'filters' more #43

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

loevgaard
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.72%. Comparing base (9499590) to head (7ae6886).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Form/Builder/SearchFormBuilder.php 0.00% 2 Missing ⚠️
src/Document/Attribute/Facetable.php 0.00% 1 Missing ⚠️
src/SetonoSyliusMeilisearchPlugin.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     32.72%   32.72%           
  Complexity      561      561           
=========================================
  Files           113      113           
  Lines          1925     1925           
=========================================
  Hits            630      630           
  Misses         1295     1295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit 55851db into master Dec 7, 2024
35 of 38 checks passed
@loevgaard loevgaard deleted the rename-facet-form-builders branch December 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant