fix(deps): update rust crate toml to v0.8.16 #409
clippy
14 errors, 1 warning
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 14 |
Warning | 1 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check failure on line 262 in src/paths.rs
github-actions / clippy
use of `unwrap_or_else` to construct default value
error: use of `unwrap_or_else` to construct default value
--> src/paths.rs:262:14
|
262 | .unwrap_or_else(PathBuf::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
Check failure on line 255 in src/hoard/pile_config.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
error: assigning the result of `Clone::clone()` may be inefficient
--> src/hoard/pile_config.rs:255:13
|
255 | self.encryption = other.encryption.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.encryption.clone_from(&other.encryption)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
note: the lint level is defined here
--> src/lib.rs:23:9
|
23 | #![deny(clippy::perf)]
| ^^^^^^^^^^^^
= note: `#[deny(clippy::assigning_clones)]` implied by `#[deny(clippy::perf)]`
Check failure on line 62 in src/diff.rs
github-actions / clippy
item in documentation is missing backticks
error: item in documentation is missing backticks
--> src/diff.rs:62:26
|
62 | /// The left path to diff_paths existed, but the right path did not.
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
62 | /// The left path to `diff_paths` existed, but the right path did not.
| ~~~~~~~~~~~~
Check failure on line 60 in src/diff.rs
github-actions / clippy
item in documentation is missing backticks
error: item in documentation is missing backticks
--> src/diff.rs:60:26
|
60 | /// The left path to diff_files did not exist, but the right path did.
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]`
help: try
|
60 | /// The left path to `diff_files` did not exist, but the right path did.
| ~~~~~~~~~~~~
Check failure on line 124 in src/checksum/digest.rs
github-actions / clippy
non-canonical implementation of `partial_cmp` on an `Ord` type
error: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/checksum/digest.rs:116:1
|
116 | / impl<T> PartialOrd for Digest<T>
117 | | where
118 | | T: Digestable,
119 | | <<T as Digestable>::OutputSize as Add>::Output: ArrayLength<u8>,
120 | | {
121 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
122 | || self.0.partial_cmp(&other.0)
123 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
124 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
note: the lint level is defined here
--> src/lib.rs:19:9
|
19 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::non_canonical_partial_ord_impl)]` implied by `#[deny(clippy::all)]`
Check failure on line 408 in src/checkers/history/operation/mod.rs
github-actions / clippy
matching over `()` is more explicit
error: matching over `()` is more explicit
--> src/checkers/history/operation/mod.rs:408:44
|
408 | self.require_latest_version().map(|_| self)
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
Check failure on line 399 in src/checkers/history/operation/mod.rs
github-actions / clippy
matching over `()` is more explicit
error: matching over `()` is more explicit
--> src/checkers/history/operation/mod.rs:399:44
|
399 | self.require_latest_version().map(|_| self)
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
Check failure on line 457 in src/checkers/history/operation/v2.rs
github-actions / clippy
you are explicitly cloning with `.map()`
error: you are explicitly cloning with `.map()`
--> src/checkers/history/operation/v2.rs:453:9
|
453 | / self.created
454 | | .get(rel_path)
455 | | .or_else(|| self.modified.get(rel_path))
456 | | .or_else(|| self.unmodified.get(rel_path))
457 | | .map(Clone::clone)
| |______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[deny(clippy::map_clone)]` implied by `#[deny(clippy::style)]`
help: consider calling the dedicated `cloned` method
|
453 ~ self.created
454 + .get(rel_path)
455 + .or_else(|| self.modified.get(rel_path))
456 + .or_else(|| self.unmodified.get(rel_path)).cloned()
|
Check failure on line 112 in src/checkers/history/operation/v2.rs
github-actions / clippy
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> src/checkers/history/operation/v2.rs:112:22
|
112 | .or_insert_with(HashSet::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
note: the lint level is defined here
--> src/lib.rs:21:9
|
21 | #![deny(clippy::style)]
| ^^^^^^^^^^^^^
= note: `#[deny(clippy::unwrap_or_default)]` implied by `#[deny(clippy::style)]`
Check failure on line 209 in src/checkers/history/operation/util.rs
github-actions / clippy
matching over `()` is more explicit
error: matching over `()` is more explicit
--> src/checkers/history/operation/util.rs:209:23
|
209 | .map(|(count, _)| count)
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
Check failure on line 204 in src/checkers/history/operation/util.rs
github-actions / clippy
matching over `()` is more explicit
error: matching over `()` is more explicit
--> src/checkers/history/operation/util.rs:204:25
|
204 | let (count, _) = acc?;
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
note: the lint level is defined here
--> src/lib.rs:24:9
|
24 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::ignored_unit_patterns)]` implied by `#[deny(clippy::pedantic)]`
Check failure on line 63 in src/config/builder/environment/exe.rs
github-actions / clippy
unnecessary qualification
error: unnecessary qualification
--> src/config/builder/environment/exe.rs:63:9
|
63 | std::fmt::Display::fmt(&self.0.display(), f)
| ^^^^^^^^^^^^^^^^^^^^^^
|
help: remove the unnecessary path segments
|
63 - std::fmt::Display::fmt(&self.0.display(), f)
63 + fmt::Display::fmt(&self.0.display(), f)
|
Check failure on line 64 in src/checksum/digest.rs
github-actions / clippy
unnecessary qualification
error: unnecessary qualification
--> src/checksum/digest.rs:64:23
|
64 | type OutputSize = <sha2::Sha256 as sha2::digest::OutputSizeUser>::OutputSize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: remove the unnecessary path segments
|
64 - type OutputSize = <sha2::Sha256 as sha2::digest::OutputSizeUser>::OutputSize;
64 + type OutputSize = <sha2::Sha256 as digest::OutputSizeUser>::OutputSize;
|
Check failure on line 56 in src/checksum/digest.rs
github-actions / clippy
unnecessary qualification
error: unnecessary qualification
--> src/checksum/digest.rs:56:23
|
56 | type OutputSize = <md5::Md5 as md5::digest::OutputSizeUser>::OutputSize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:61:1
|
61 | unused_qualifications,
| ^^^^^^^^^^^^^^^^^^^^^
help: remove the unnecessary path segments
|
56 - type OutputSize = <md5::Md5 as md5::digest::OutputSizeUser>::OutputSize;
56 + type OutputSize = <md5::Md5 as digest::OutputSizeUser>::OutputSize;
|
Check warning on line 46 in src/lib.rs
github-actions / clippy
lint `private_in_public` has been removed: replaced with another group of lints, see RFC <https://rust-lang.github.io/rfcs/2145-type-privacy.html> for more information
warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC <https://rust-lang.github.io/rfcs/2145-type-privacy.html> for more information
--> src/lib.rs:46:1
|
46 | private_in_public,
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(renamed_and_removed_lints)]` on by default