Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vulnarable SkiaSharp version #385

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

Bykiev
Copy link
Contributor

@Bykiev Bykiev commented Feb 15, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Update vulnarable SkiaSharp version to the latest. Also update BenchmarkDotNet to latest version

Update vulnarable SkiaSharp version to latest. Also update BenchmarkDotNet to latest version
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (977001a) to head (15b7f8e).
Report is 16 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main    #385    +/-   ##
======================================
  Coverage     86%     86%            
======================================
  Files        238     238            
  Lines      15184   15229    +45     
  Branches    2101    2108     +7     
======================================
+ Hits       13088   13189   +101     
+ Misses      1613    1566    -47     
+ Partials     483     474     -9     
Flag Coverage Δ
unittests 86% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -30,7 +30,7 @@
</Choose>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" />
<PackageReference Include="SkiaSharp" />
<PackageReference Include="BenchmarkDotNet" Version="0.13.12" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want the version number here. That's handled in the targets file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was added by Nuget, will fix it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@JimBobSquarePants JimBobSquarePants merged commit d24a330 into SixLabors:main Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants