Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert mandatory break when line is broken by wrapping. #433

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Dec 16, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #431

Added a new check to handle cases where a new line starts with a mandatory line break after a non-mandatory break has been added due to wrapping.

Output rendered using sample project.

testImg3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • samples/DrawWithImageSharp/DrawWithImageSharp.csproj: Language not supported
@JimBobSquarePants JimBobSquarePants merged commit 7cfff73 into main Dec 16, 2024
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-line-break branch December 16, 2024 10:36
@jez9999
Copy link

jez9999 commented Dec 16, 2024

This is definitely better for my purposes, but alas I did still notice a small bug with it. 😄 Now, 2 explicit newlines only get rendered as 1 newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary text wrap when newline separates words instead of space
3 participants