Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 zh_cn translation #5286

Open
wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
Open

Conversation

JasonQ1123
Copy link

I've translated the untranslated parts of the new content to chinese and would like to request a merge. Tysm!

@Cactusstudent
Copy link
Contributor

Cactusstudent commented Dec 29, 2024

首先,1.20.1 还属于正在开发的版本(甚至并没有 Alpha 版本),目前特性尚不稳定,这时候贡献翻译显然是不太明智的。
其次,注意到您的译文当中存在部分与当前游戏内已有译文不一致的部分,同时存在不符合中文标准化译名的部分(例如:Chiseled 应当翻译为雕纹而非旧版本的錾质)
接着,将所有的新增译文放在文件最后并不是一个好主意,会对之后的维护造成极大的困难
最后,感谢您的贡献,我已经制作了一份不太完善的匠魂 3 中文本地化(1.20.1),敬请参见此处,也可给予批评指正,我将在合适的时间将这些更改推送到官方。


Firstly, 1.20.1 is under developing (not have an alpha version now), some feature may work inproperly. In my view, it's not wise to contribute Chinsese localization now.
Secondly, I noticed your translation have something wrong with certain translation, and many also have some standarization mistakes, such as Chiseled (the Chinese localization had changed to 雕纹 in 1.19.3) etc.
Then, put every localization keys in the end of the file may not a good idea, it may lead a diffeculty to the future work,
But, thanks for your contribution, I have made a incomplete localization for TiC3 1.20.1, you can view here and remark. I'll send these commits to SlimeKnight in right time

@JasonQ1123
Copy link
Author

OK,感谢,有些翻译我觉得可以稍微斟酌一下(你制作的那一份),主要是melting_pan那一部分,我个人愚见是觉得翻译成烹饪锅或者炒菜锅会更加合适一点,毕竟这个锅可以放食物进去并且烹饪,并且在工匠大百科这本书中显示的GUI也是营火烟熏的形式,其余的你提出的问题我觉得挺对的,放在最后是因为添加missing translatekey的时候没有排序(忘了点了),最后还是感谢你的评论
顺便问一句,1201有无具体的发版计划?还是想尽快玩到高版本的匠魂的,特别是我还是一位整合包制作者的前提下,我很希望能把匠魂整合进入我的下一个整合包中。

@Cactusstudent
Copy link
Contributor

Cactusstudent commented Dec 29, 2024

OK,感谢,有些翻译我觉得可以稍微斟酌一下(你制作的那一份),主要是melting_pan那一部分,我个人愚见是觉得翻译成烹饪锅或者炒菜锅会更加合适一点,毕竟这个锅可以放食物进去并且烹饪,并且在工匠大百科这本书中显示的GUI也是营火烟熏的形式

Melting pan 这玩意我主要是考虑到还能冶炼矿石,所以用了一个两边说着都不奇怪的词语()如果觉得我的这份译本还能信得过的话就请拿去吧,留个署名就行
而对于模组来说,确实是无ETA的,就慢慢等吧,着急不得

@JasonQ1123
Copy link
Author

Melting pan 这玩意我主要是考虑到还能冶炼矿石,所以用了一个两边说着都不奇怪的词语()如果觉得我的这份译本还能信得过的话就请拿去吧,留个署名就行
而对于模组来说,确实是无ETA的,就慢慢等吧,着急不得

我也是单纯提一下我的意见,因为我感觉冶炼矿石其实并不是他最亮眼的功能,或者说我觉得可能并非主要功能?不过具体意思我觉得可以去询问一下slimeknights的意见,询问一下他当时为什么要注册为melting pan(),顺便我觉得你的译本很不错,我很乐意见到你把译文提交给官方;没有ETA的化那就只能等待了😭

@KnightMiner KnightMiner added Translation Pull request or issues related to improving translations or the English text in game 1.20 Issue affects 1.20 labels Dec 29, 2024
@KnightMiner
Copy link
Member

KnightMiner commented Dec 29, 2024

OK,感谢,有些翻译我觉得可以稍微斟酌一下(你制作的那一份),主要是melting_pan那一部分,我个人愚见是觉得翻译成烹饪锅或者炒菜锅会更加合适一点,毕竟这个锅可以放食物进去并且烹饪,并且在工匠大百科这本书中显示的GUI也是营火烟熏的形式,其余的你提出的问题我觉得挺对的,放在最后是因为添加missing translatekey的时候没有排序(忘了点了),最后还是感谢你的评论 顺便问一句,1201有无具体的发版计划?还是想尽快玩到高版本的匠魂的,特别是我还是一位整合包制作者的前提下,我很希望能把匠魂整合进入我的下一个整合包中。

The melting pan cannot be used to cook food. It is not a frying pan or a cooking pot, it only works on ores. So yes, melting ores is the function that should be highlighted in the name as that is the function highlighted in the english name.

The smelting modifier is unrelated to the melting pan, "smelting" tends to refer to the furnace recipes while "melting" refers to our own recipes turning items into liquids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Translation Pull request or issues related to improving translations or the English text in game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants