Change some recipes to use LazyToolStack for results #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and changed TinkerStationScreen for using LazyToolStack
|
I’ll fix those conflicts |
|
Whoops, did not meant to delete the branch this PR was targeted at. Was deleting a couple other branches when it was encountered. I was too far into the port to look into this originally pre-1.20, and it turns out Mojang's recipe access changes made 1.20 a pretty big burden, so it will probably be necessary to fix some conflicts for this to work on 1.20. Otherwise, I can revisit your 1.19 version and just handle the conflicts myself via cherry pick. |
|
No problem. And not sure what timeline you were looking for, but I can probably take a crack at it myself in the next few days |
|
No rush. The alpha I released today said more API breaks are likely happening, this is one I planned for. |
…ruct into nobuild-api-break # Conflicts: # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/AbstractModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/IncrementalModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/ModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/MultilevelModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/OverslimeModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/modifiers/adding/SwappableModifierRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/tinkerstation/ITinkerStationRecipe.java # src/main/java/slimeknights/tconstruct/library/recipe/tinkerstation/repairing/ModifierRepairTinkerStationRecipe.java # src/main/java/slimeknights/tconstruct/tables/block/entity/table/TinkerStationBlockEntity.java # src/main/java/slimeknights/tconstruct/tables/client/inventory/ModifierWorktableScreen.java # src/main/java/slimeknights/tconstruct/tables/client/inventory/TinkerStationScreen.java # src/main/java/slimeknights/tconstruct/tables/recipe/TinkerStationDamagingRecipe.java # src/main/java/slimeknights/tconstruct/tables/recipe/TinkerStationPartSwapping.java # src/main/java/slimeknights/tconstruct/tables/recipe/TinkerStationRepairRecipe.java
KnightMiner
added
Technical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5282, for #5281