[Core] Feature #3432, add the Healthcheck Page #3450
Conversation
| if ($numberOfReplicas > 1 && $numberOfReplicas > ($numberOfNodes - 1)) { | ||
| return 'warning'; |
There was a problem hiding this comment.
Legacy check was actually wrong.
"$numberOfReplicas > ($numberOfNodes - 1)" is ok.
But the first part should be "$numberOfReplicas > 0".
=> "If the number of replicas > 0 (it means we enabled replicas) then, there is a warning if there are more replicas than available nodes".
| * @license Open Software License ("OSL") v. 3.0 | ||
| */ | ||
|
|
||
| namespace Smile\ElasticsuiteCore\Healthcheck; |
There was a problem hiding this comment.
Could you move those 4 healthchecks models into "Model\Healthcheck" ?
| /** | ||
| * Class GenericWarningAboutClusterMisconfig | ||
| */ | ||
| class GenericWarningAboutClusterMisconfig implements MessageInterface |
There was a problem hiding this comment.
Could you rename that class as "GenericHealthcheckWarning" instead ?
For now, the healthchecks are essentially about cluster configuration, but in the long run, they could be about the tracker, too many thesausurus definition, etc.
| @@ -22,7 +22,19 @@ | |||
| <arguments> | |||
| <argument name="messages" xsi:type="array"> | |||
| <item name="elasticsuite" xsi:type="string">Smile\ElasticsuiteCore\Model\System\Message\NotificationAboutVersions</item> | |||
| <item name="elasticsuite_cluster_replicas_misconfig_warning" xsi:type="string">Smile\ElasticsuiteCore\Model\System\Message\WarningAboutClusterReplicasMisconfig</item> | |||
| <!-- Generic warning class --> | |||
| <item name="elasticsuite_cluster_generic_misconfig_warning" xsi:type="string">Smile\ElasticsuiteCore\Model\System\Message\GenericWarningAboutClusterMisconfig</item> | |||
There was a problem hiding this comment.
Same goes as for the class name, "elasticsuite_generic_healthcheck_warning" would be better here to be consistent.
vahonc
force-pushed
the
3432-elasticsuite-core-healthcheck-page-2.10-feature
branch
from
04615ea to
377920f
Compare
vahonc
force-pushed
the
3432-elasticsuite-core-healthcheck-page-2.10-feature
branch
from
28bde53 to
af47e82
Compare
No description provided.