Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to specify user for exec command. #511

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Conversation

sfc-gh-mwalas
Copy link
Collaborator

No description provided.

@sfc-gh-mwalas sfc-gh-mwalas marked this pull request as ready for review November 14, 2024 10:30
Copy link
Collaborator

@sfc-gh-iyashchyshyn sfc-gh-iyashchyshyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, LGTM otherwise.

Copy link
Collaborator

@sfc-gh-psmolenski sfc-gh-psmolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sfc-gh-ikryvanos sfc-gh-ikryvanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sfc-gh-psmolenski and others added 2 commits November 21, 2024 17:28
* `file cp --mode` will always be treated as a 12-bit octal number.
* `file chmod --mode` will always be treated as a 12-bit octal number.
* `file mkdir --mode` will always be treated as a 12-bit octal number.
* Changed error `file chmod` message when `--mode` is empty.
* Added `--mode` format description to `mkdir`, `cp` and `chmod` commands help.
* Added documentation for `file cp`
* Added documentation for `file mkdir`
@sfc-gh-mwalas
Copy link
Collaborator Author

Would you mind to add readme similar to https://github.com/Snowflake-Labs/sansshell/blob/main/services/network/README.md ?

Added, yet as we should talk further on how to auto-generate those from Usage() command line help and improve those pages.

@sfc-gh-mwalas sfc-gh-mwalas merged commit 8959808 into main Nov 22, 2024
7 checks passed
@sfc-gh-mwalas sfc-gh-mwalas deleted the mwalas-exec-user branch November 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants