Fixed inconsistent parsing of --mode flag
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-psmolenski
requested review from
sfc-gh-mwalas,
sfc-gh-ikryvanos and
sfc-gh-iyashchyshyn
sfc-gh-mwalas
approved these changes
Nov 15, 2024
sfc-gh-iyashchyshyn
approved these changes
Nov 18, 2024
sfc-gh-ikryvanos
approved these changes
Nov 21, 2024
…sed only in `client` file.
sfc-gh-psmolenski
force-pushed
the
localfile-mode-inconsistency
branch
from
ab742df to
49f35fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to default Go's sting-to-int parsing algorithm the value of
--modeflag was treated as decimal or octal depending on its format (777vs.0777), which was yielding unexpected results and was inconsistent with how native UNIX tools work (e.g.chmod) .From now on,
sansshclient will always treat--modeflag value as a 12-bit octal number.