Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable timeout for dmesg scan #518

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

sfc-gh-iyashchyshyn
Copy link
Collaborator

Limited from 2 to 30 seconds, value is passed in seconds. Also includes some docs for sysinfo.

Copy link
Collaborator

@sfc-gh-mwalas sfc-gh-mwalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider passing around Duration instead of # of seconds.

services/sysinfo/client/client.go Outdated Show resolved Hide resolved
services/sysinfo/sysinfo.proto Outdated Show resolved Hide resolved
services/sysinfo/server/sysinfo_linux.go Outdated Show resolved Hide resolved
services/sysinfo/server/sysinfo_linux.go Outdated Show resolved Hide resolved
services/sysinfo/client/client.go Outdated Show resolved Hide resolved
services/sysinfo/server/sysinfo.go Show resolved Hide resolved
@sfc-gh-iyashchyshyn sfc-gh-iyashchyshyn merged commit 9e44ac1 into main Dec 19, 2024
7 checks passed
@sfc-gh-iyashchyshyn sfc-gh-iyashchyshyn deleted the iyashchyshyn/configurable-dmesg-time branch December 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants