Merge branch 'main' into moviepy2

Softcatala · Dec 19, 2024 · f06769a · f06769a
2 parents 82e334b + 58db5e9
commit f06769a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-.PHONY: dev run-tests
+.PHONY: dev run-tests run-e2e-tests publish-release
 
 PATHS = open_dubbing/ tests/ e2e-tests/
 

diff --git a/open_dubbing/ffmpeg.py b/open_dubbing/ffmpeg.py
@@ -93,7 +93,7 @@ def embed_subtitles(
         video_file: str,
         subtitles_files: List[str],
         languages_iso_639_3: List[str],
-    ) -> str:
+    ):
         filename = ""
         with tempfile.NamedTemporaryFile(delete=False) as temp_file:
             shutil.copyfile(video_file, temp_file.name)
@@ -131,14 +131,12 @@ def embed_subtitles(
             logging.debug(f"embed_subtitles. Command: {' '.join(cmd)}")
 
             # Run the command using the _run method
-            self._run(command=cmd, fail=True)
+            self._run(command=cmd, fail=False)
             filename = temp_file.name
 
         if os.path.exists(filename):
             os.remove(filename)
 
-        return output_file
-
     @staticmethod
     def is_ffmpeg_installed():
         cmd = ["ffprobe", "-version"]