Skip to content

Commit

Permalink
chore: use node v20 in GH actions
Browse files Browse the repository at this point in the history
  • Loading branch information
dziraf committed Feb 20, 2024
1 parent c013a17 commit 2e92ca1
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 117 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Setup
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
- name: Install
run: yarn install --frozen-lockfile
Expand All @@ -26,7 +26,7 @@ jobs:
- name: Setup
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
- name: Install
run: yarn install
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Setup
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
- name: Install
run: yarn install
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
- name: Setup
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
- name: Install
run: yarn install
Expand Down
72 changes: 0 additions & 72 deletions bin/bundle-globals.js

This file was deleted.

36 changes: 0 additions & 36 deletions bin/watch-dev.js

This file was deleted.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@
"semantic-release-slack-bot": "^4.0.0",
"sinon": "^15.0.2",
"sinon-chai": "^3.7.0",
"ts-node": "^10.9.2",
"typescript": "^5.3.3"
},
"resolutions": {
Expand Down
9 changes: 4 additions & 5 deletions src/backend/utils/router/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { createRequire } from 'node:module'

import AppController from '../../controllers/app-controller.js'
import ApiController from '../../controllers/api-controller.js'
import env from '../../bundler/bundler-env.js'
import { COMPONENTS_OUTPUT_PATH } from '../../bundler/utils/constants.js'
import { COMPONENTS_OUTPUT_PATH, NODE_ENV } from '../../bundler/utils/constants.js'

const __dirname = url.fileURLToPath(new URL('.', import.meta.url))
const ASSETS_ROOT = `${__dirname}/../lib/../../../frontend/assets/`
Expand All @@ -20,7 +19,7 @@ const resolveDesignSystemBundle = (): string => {

return path.join(
path.parse(require.resolve('@adminjs/design-system')).dir,
`../bundle.${env}.js`,
`../bundle.${NODE_ENV}.js`,
)
}

Expand Down Expand Up @@ -65,10 +64,10 @@ export const Router: RouterType = {
src: path.join(ASSETS_ROOT, 'fonts/icomoon.woff'),
}, {
path: '/frontend/assets/app.bundle.js',
src: path.join(ASSETS_ROOT, `scripts/app-bundle.${env}.js`),
src: path.join(ASSETS_ROOT, `scripts/app-bundle.${NODE_ENV}.js`),
}, {
path: '/frontend/assets/global.bundle.js',
src: path.join(ASSETS_ROOT, `scripts/global-bundle.${env}.js`),
src: path.join(ASSETS_ROOT, `scripts/global-bundle.${NODE_ENV}.js`),
}, {
path: '/frontend/assets/design-system.bundle.js',
src: resolveDesignSystemBundle(),
Expand Down
19 changes: 19 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9861,6 +9861,25 @@ ts-node@^10.8.1:
v8-compile-cache-lib "^3.0.1"
yn "3.1.1"

ts-node@^10.9.2:
version "10.9.2"
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.9.2.tgz#70f021c9e185bccdca820e26dc413805c101c71f"
integrity sha512-f0FFpIdcHgn8zcPSbf1dRevwt047YMnaiJM3u2w2RewrB+fob/zePZcrOyQoLMMO7aBIddLcQIEK5dYjkLnGrQ==
dependencies:
"@cspotcode/source-map-support" "^0.8.0"
"@tsconfig/node10" "^1.0.7"
"@tsconfig/node12" "^1.0.7"
"@tsconfig/node14" "^1.0.0"
"@tsconfig/node16" "^1.0.2"
acorn "^8.4.1"
acorn-walk "^8.1.1"
arg "^4.1.0"
create-require "^1.1.0"
diff "^4.0.1"
make-error "^1.1.1"
v8-compile-cache-lib "^3.0.1"
yn "3.1.1"

tsconfig-paths@^3.14.1:
version "3.14.2"
resolved "https://registry.yarnpkg.com/tsconfig-paths/-/tsconfig-paths-3.14.2.tgz#6e32f1f79412decd261f92d633a9dc1cfa99f088"
Expand Down

0 comments on commit 2e92ca1

Please sign in to comment.