use check_output to enable better error detection

Solvik · Dec 22, 2024 · e5b6ec8 · e5b6ec8
1 parent d4546b4
commit e5b6ec8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/netbox_agent/hypervisor.py b/netbox_agent/hypervisor.py
@@ -1,4 +1,5 @@
 import logging
+import shlex
 import subprocess
 
 from netbox_agent.config import config
@@ -44,7 +45,8 @@ def create_netbox_virtual_guest(self, name):
         return guest
 
     def get_virtual_guests(self):
-        return subprocess.getoutput(config.virtual.list_guests_cmd).split()
+        output = subprocess.check_output(shlex.split(config.virtual.list_guests_cmd))
+        return output.decode("utf-8")
 
     def create_or_update_device_virtual_machines(self):
         nb_guests = self.get_netbox_virtual_guests()