Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcommuni IRC backend: support multi-lines messages #306

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

Niluge-KiWi
Copy link

... by splitting them into one PRIVMSG command per line.

Closes #305

... by splitting them into one PRIVMSG command per line.
@Niluge-KiWi
Copy link
Author

Done

Split on \n, send a Message for each line.

Limitations

  • I did not support message splitting for the CTCP Action as I don't know what it is and cannot test it.
  • I did not try to skip empty lines, it seem to create warnings on freenode.
  • I did not handle \r, as I don't encounter it in my personal use, but it could be added later (tricky part: don't send an empty message for the empty string between them in \r\n)

@vitalyster vitalyster merged commit d7ffa36 into SpectrumIM:master Aug 26, 2018
@Niluge-KiWi Niluge-KiWi deleted the irc-newlines branch April 6, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants