Skip to content

Commit

Permalink
🐛 Fix completion inside unclosed records
Browse files Browse the repository at this point in the history
The code used to assume that the first and last characters in the range
of a record node are the brackets. No completions would be suggested for
key-value pairs when the cursor is at either end of the range, as that
is assumed to be outside the brackets. However, this assumption is
violated when there is no closing bracket, which is a common occurrence
during editing for users who do not rely on their editor to
automatically close brackets. This commit fixes the issue by keeping
track of the actual range inside the brackets.
  • Loading branch information
ulrikdem committed Aug 25, 2024
1 parent 540c39f commit 6a8adf1
Show file tree
Hide file tree
Showing 24 changed files with 916 additions and 189 deletions.
108 changes: 90 additions & 18 deletions __snapshots__/packages/core/test-out/parser/record.spec.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6a8adf1

Please sign in to comment.