🔥 Remove old json checkers #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAfroOfDoom
suggested changes
May 11, 2024
There was a problem hiding this comment.
can we also remove the snapshot code that is generated by tests that used testGrid / testChecker?
i don't know if theres a more official way of updating snapshots but ive just been deleting the relevant file(s) and re-running npm run test (this is more of a "how do you do it?" question than a "this is how you should do it")
|
Setting the environment variable |
SPGoding
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to have this old system confusing us when it's going to be replaced by mcdoc.