Open pywinrm shell sessions with UTF-8 codepage #6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Stealthii
added a commit
to Stealthii/st2
that referenced
this pull request
Oct 18, 2023
Stealthii
force-pushed
the
bugfix/winrm_runner-unicode
branch
from
1755d69 to
173ed22
Compare
nzlosh
approved these changes
Oct 18, 2023
Stealthii
force-pushed
the
bugfix/winrm_runner-unicode
branch
from
173ed22 to
5cdc0e7
Compare
cognifloyd
approved these changes
Feb 19, 2024
With Python 3.6 being the minimum supported version, dropping six here and utilising 3.x type identifiers.
This change opens a shell with the 65001 codepage, ensuring raw string responses are UTF-8 encoded. Fixes StackStorm#6034.
auto-merge was automatically disabled
October 16, 2024 19:36
Head branch was pushed to by a user without write access
Stealthii
force-pushed
the
bugfix/winrm_runner-unicode
branch
from
67fd29f to
dcf7c30
Compare
|
@nzlosh @cognifloyd re-based this PR and fixed the changelog conflicts and formatting standard to match recent entries, apologies for the delay! |
|
Thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a change to the shell initialisation process with pywinrm, utilizing the 65001 codepage, ensuring raw string responses are UTF-8 encoded.
Potential fix for #6034.