pants ci: add integration tests jobs #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
pants-itests
branch
10 times, most recently
from
6575608 to
7f869b9
Compare
pull-request-size
bot
added
size/XL
cognifloyd
force-pushed
the
pants-itests
branch
3 times, most recently
from
1d377cb to
11b7e65
Compare
pull-request-size
bot
added
size/XXL
cognifloyd
force-pushed
the
pants-itests
branch
from
ca88923 to
b03451a
Compare
pull-request-size
bot
added
size/M
cognifloyd
force-pushed
the
pants-itests
branch
from
b03451a to
8a8db1b
Compare
pull-request-size
bot
added
size/L
cognifloyd
force-pushed
the
pants-itests
branch
from
f763c45 to
76c918f
Compare
|
Planned sequence of PRs: flowchart LR
A("✅ #6275: BUILD metadata") --> D("✅ #6279: pants-plugins/uses_services st2cluster")
D ---> H("⏳ #6273: Add integration tests job")
B("✅ #6276: Refactor CI scripts") ---> G("✅ #6283: Add redis namespace + ST2_* ST2TESTS_* vars in launchdev.sh")
G --> H
C("✅ #6277: env var support") --> E("✅ #6278: pants-plugins/uses_services refactor + mongo")
E --> F("✅ #6282: Add messaging.prefix option") & G
F --> H
|
winem
approved these changes
Nov 16, 2024
This was referenced Nov 17, 2024
pants `--tag=...` notes:
`--tags=abc,def` (a csv list):
is an OR condition (either `abc` tag, or `def` tag, or both).
`--tags=abc --tag=def` (multiple entries):
is an AND condition (Both `abc` tag AND `def` tag).
So, we use `--tag=integration --tag=-st2cluster` to select targets
that have the `integration` tag AND do NOT have the `st2cluster` tag.
pants `--tag=...` notes:
`--tags=abc,def` (a csv list):
is an OR condition (either `abc` tag, or `def` tag, or both).
`--tags=abc --tag=def` (multiple entries):
is an AND condition (Both `abc` tag AND `def` tag).
So, we use `--tag=integration --tag=st2cluster` to select targets
that have the `integration tag AND the `st2cluster` tag.
(The other integration test job excludes the st2cluster tagged targets).
cognifloyd
force-pushed
the
pants-itests
branch
from
b98e5ae to
432a6ca
Compare
pull-request-size
bot
added
size/L
cognifloyd
changed the title
cognifloyd
commented
Nov 29, 2024
Comment on lines
+261
to
+262
| "ST2_CI", | ||
| "ST2_CI_RUN_ORQUESTA_PAUSE_RESUME_TESTS", |
There was a problem hiding this comment.
These vars are used to skip some integration tests unless running in CI.
|
|
||
| - name: Integration Tests | ||
| env: | ||
| ST2_CI_RUN_ORQUESTA_PAUSE_RESUME_TESTS: 'true' |
There was a problem hiding this comment.
With all of the recent changes to use redis and to make running tests in parallel safer, and with pants+pytest running the tests, I attempted to run tests that we've been skipping even in CI for a while. Happily, they seem much more reliable now, so this line re-enables the tests in pants+pytest CI.
cognifloyd
requested review from
nzlosh,
rush-skills,
guzzijones,
amanda11 and
a team
nzlosh
reviewed
Dec 4, 2024
| # setup virtualenv step will fail. | ||
| python: | ||
| - {version-short: '3.8', version: '3.8.10'} | ||
| - {version-short: '3.9', version: '3.9.14'} |
There was a problem hiding this comment.
Why isn't python 3.10 being tested here also?
There was a problem hiding this comment.
We haven't merged the changes that add 3.10 to any of the other CI jobs yet. I plan to work on that once I've got the self check running with pants.
nzlosh
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 GHA jobs to the pants+pytest CI workflow:
integration-testsintegration-st2cluster-testsSadly, GHA is very repetitive, so a lot of the steps for these jobs are just copies of steps in other jobs. So, this should be fairly easy to review despite the line count. Go through each commit to see why I made a few changes to some steps.
Currently, we run Makefile-based integration tests in CI and Orquesta CI workflows. For the pants+pytest CI, I opted to do 2 jobs instead of separate workflows. Also, I found that the only integration tests that require a running st2cluster (started with
tools/launchdev.sh) are the orquesta tests. Since st2cluster is not required by most integration tests, I was able to simplify the setup and avoid starting it. This also means there will be far fewer logs to go through when looking up failures about one of these integration tests. So, I used that requirement (needs a running st2cluster) as the dividing line between the 2 sets of integration tests. By using "st2cluster" instead of "orquesta" in the job name, I created an (hopefully) obvious home for future non-orquesta tests that need to use st2cluster.These PRs were split out of this PR to keep each PR focused and easier to review:
st2.confsettings via env vars #6277ST2_DATABASE__*vars #6278[messaging].prefixto configure prefix of RabbitMQ exchange/queue names #6282