-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Document using pantsbuild #1143
base: master
Are you sure you want to change the base?
Conversation
I've looked at the developer docs, and it's really hard to make sense of what should be where. What follows is a bit of a braindump about how to proceed. So, I'm taking a step back to try and use the Diátaxis framework evaluate what we might need*.
There are four kinds of documentation in Diátaxis: Tutorials, How-to Guides, Reference, Explanation. Looking specifically at the Development branch of our documentation--the section that targets StackStorm contributors and TSC members instead of StackStorm users--we have all four of these on the same page. Mapping out exactly where everything should be feels a bit overwhelming, but apparently we don't need to (see: How to Use Diátaxis):
We have docs that serve multiple purposes mixed together in the dev docs, and we should be able to take iterative steps towards reorganizing it. We also need to document how to do various things with pants, because that should simplify the dev processes and make them more discoverable (w/ So, as I write new documentation about pants, I should add it in a new page, referring to Diátaxis to figure out which purpose that page should serve and where it should go. Then, figure out if that any existing docs can be moved into that page, or it the page replaces any docs sections so it can be removed or updated to refer to the new page. *: I forget where I first heard about this framework, but I watched this talk before I found the website: https://youtu.be/t4vKPhjcMZg |
@@ -1,6 +1,8 @@ | |||
Development | |||
=========== | |||
|
|||
<!-- TODO: update to describe development using pantsbuild --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need a small section somewhere after Pre commit hook
Just having a couple of commands hinting how to build things with pants for someone residing in the stackstorm repo would be sufficient or perhaps even a more high-level overview of the 2-3 steps that pants does referring to their official docs. There is no need of a big write-up and explanation and we should stick with the format/size that's already used, like an existing "Code Style Guide". |
Background
This is part of introducing
pants
, as discussed in the TSC Meetings on 12 July 2022 and 02 Aug 2022. Pants has fine-grained per-file caching of results for lint, fmt (like black), test, etc. It also has lockfiles that work well for monorepos that have multiple python packages. With these lockfiles CI should not break when any of our dependencies or our transitive dependencies release new versions, because CI will continue to use the locked version until we explicitly relock with updates.Overview of this PR
As we replace the Makefile and other parts of our CI and development infrastructure, the development and contributing guidelines need to be updated. As we integrate pantsbuild in the main st2 repo, we can document changed processes in the
pantsbuild
branch (this PR). Any of the TSC members can push to this branch, so we can collaboratively update the documentation.PRs in StackStorm/st2