Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up frustum_cull_test example #589

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

rparrett
Copy link
Collaborator

  • Show instructions and current map type on screen with good contrast in the UI layer

That was my original goal, but I felt like this thing really needed some attention. I am often scratching my head at what it's supposed to be doing when returning to this repo to test.

  • Separate code responsible for determining next map type and changing map properties for clarity
  • Get helpers::camera::movement out of the First schedule
  • Remove "mouse picking" comments not related to this example
  • Combine texture handle resources
  • Tidy up imports
  • Other misc cleanup

A lot of these improvements should be implemented in other examples as well. I think we should consider pruning the hexagon examples first. See #588.

@ChristopherBiscardi ChristopherBiscardi merged commit 8ccbd6b into StarArawn:main Dec 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants