Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes AD NaN issue. #3

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Fixes AD NaN issue. #3

merged 1 commit into from
Feb 2, 2019

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Feb 2, 2019

cf tpapp/DynamicHMCExamples.jl#12

note that the transformation accessors no longer get forwarded, I also
fixed that.

Uses LogDensityProblems v0.6.0 which I just tagged, should trickle
through the registry soon.

cf tpapp/DynamicHMCExamples.jl#12

note that the transformation accessors no longer get forwarded, I also
fixed that.

Uses LogDensityProblems v0.6.0 which I just tagged, should trickle
through the registry soon.
@goedman goedman merged commit a225fbc into StatisticalRethinkingJulia:master Feb 2, 2019
@tpapp tpapp deleted the fix/rejected branch February 2, 2019 14:35
@goedman
Copy link
Member

goedman commented Feb 2, 2019

Thanks a lot Tamas! Definitely runs to completion now. Will complete several more of the SR (StatisticalRethinking) examples and compare draw density graphs.

I must say, apart from really enjoying doing these examples in DynamicHMC style, using the DynamicHMC package is changing my thinking how to proceed with SR.

Also will restructure SR to make it into a separate Github org with separate packages for the 4 used mcmc solutions (right now it is recompiling SR all the time, just too slow). And it doesn't really belong to StanJulia per se.

@tpapp
Copy link
Contributor Author

tpapp commented Feb 2, 2019

I am happy to hear that you find DynamicHMC useful. Note that there will be an upcoming API reorganization in the near future (2-3 months), see the issue tpapp/DynamicHMC.jl#30 if you would like to suggest anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants