Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the creation of the main tag on Docker Hub #166

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Prevent the creation of the main tag on Docker Hub #166

merged 8 commits into from
Oct 16, 2023

Conversation

ritikverma2000
Copy link
Contributor

No description provided.

@ritikverma2000 ritikverma2000 mentioned this pull request Oct 16, 2023
Closed
MartelliEnrico
MartelliEnrico requested changes Oct 16, 2023
View reviewed changes
.github/workflows/docker-image.yml
@@ -31,7 +31,7 @@ jobs:
images: |
rob93c/stickerify
tags: |
type=raw,value=latest,enable={{is_default_branch}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain as it is, since this is for the latest tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/workflows/docker-image.yml Outdated
@@ -31,7 +31,7 @@ jobs:
images: |
rob93c/stickerify
tags: |
type=raw,value=latest,enable={{is_default_branch}}
type=ref,event=latest,enable=${{ github.ref != 'refs/heads/main' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change should be applied here, as described in the related issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got you @MartelliEnrico

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, I commented on the wrong line, I meant the one below acrually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check now @MartelliEnrico.

MartelliEnrico
MartelliEnrico approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@MartelliEnrico MartelliEnrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritikverma2000
Copy link
Contributor Author

LGTM

@MartelliEnrico can you check from your end if is it still picking up main or not ?

@rob93c
Copy link
Member

rob93c commented Oct 16, 2023

Hi @ritikverma2000, we won't be able to check if the changes work until we merge them.
I personally verified the same changes against one of my repositories and it was working fine (as I wrote in the issue docker/metadata-action#347).

@rob93c rob93c merged commit b6c9b61 into Stickerifier:main Oct 16, 2023
5 of 6 checks passed
@rob93c rob93c added the hacktoberfest-accepted This work is valid for Hacktoberfest label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartelliEnrico MartelliEnrico MartelliEnrico approved these changes

@rob93c rob93c rob93c approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted This work is valid for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritikverma2000 @rob93c @MartelliEnrico